Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump Makefile dependency versions #2445

Merged
merged 1 commit into from
Oct 18, 2023
Merged

🌱 Bump Makefile dependency versions #2445

merged 1 commit into from
Oct 18, 2023

Conversation

killianmuldoon
Copy link
Contributor

Bump dependencies for:

  • envtest
  • gotestsum
  • conversion-gen
  • yq
  • govulncheck

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (442524b) 62.95% compared to head (c0bbde7) 62.75%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2445      +/-   ##
==========================================
- Coverage   62.95%   62.75%   -0.20%     
==========================================
  Files         122      122              
  Lines        8770     8770              
==========================================
- Hits         5521     5504      -17     
- Misses       2858     2871      +13     
- Partials      391      395       +4

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chrischdi
chrischdi reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a268322da98ef4f255d7dca948320c6759b6be9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 783bdaf into kubernetes-sigs:main Oct 18, 2023
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 18, 2023
@MrDXY
Copy link
Contributor

MrDXY commented Oct 18, 2023

Hi, @killianmuldoon, I found the make test could fail on the master branch(locally executed on mac, not sure if this is only my case). But if I change the
export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.28.0 to
export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.27.1
the test passes.

Also, the error message indicates: unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH.

Would you mind taking a quick look? Or maybe I should check my environment setup.

@killianmuldoon killianmuldoon mentioned this pull request Oct 18, 2023
Merged
@killianmuldoon
Copy link
Contributor Author

@MrDXY thanks for catching that - I have the version set outside my environment locally.

Can you see if the changes in #2446 fix the issue for you?

@MrDXY
Copy link
Contributor

MrDXY commented Oct 18, 2023

I re-run make test locally, but the error persists. Also, I found a stack trace which may help resolve it. And I will double-check my environment settings tomorrow. Hope I didn't get you in the wrong direction.

------------------------------
[SynchronizedBeforeSuite] [FAILED] [0.008 seconds]
[SynchronizedBeforeSuite] 
/Users/dxinyuan/MrDXY/cluster-api-provider-vsphere/pkg/identity/identity_suite_test.go:74

  Timeline >>
  STEP: Creating new test environment @ 10/18/23 21:20:33.248
  [FAILED] in [SynchronizedBeforeSuite] - /Users/dxinyuan/MrDXY/cluster-api-provider-vsphere/pkg/identity/identity_suite_test.go:79 @ 10/18/23 21:20:33.256
  << Timeline

  [FAILED] Unexpected error:
      <*fmt.wrapError | 0x1400031f3c0>: 
      unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH
      {
          msg: "unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: \"etcd\": executable file not found in $PATH",
          err: <*fmt.wrapError | 0x1400031f3a0>{
              msg: "failed to start the controlplane. retried 5 times: exec: \"etcd\": executable file not found in $PATH",
              err: <*exec.Error | 0x1400031f360>{
                  Name: "etcd",
                  Err: <*errors.errorString | 0x1400010a3e0>{
                      s: "executable file not found in $PATH",
                  },
              },
          },
      }
  occurred
  In [SynchronizedBeforeSuite] at: /Users/dxinyuan/MrDXY/cluster-api-provider-vsphere/pkg/identity/identity_suite_test.go:79 @ 10/18/23 21:20:33.256
------------------------------

@killianmuldoon
Copy link
Contributor Author

Would be good to see what comes up as the command when you run make test let's maybe continue this conversation in slack though 😅 could you open a thread when you come back around to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@MaxRink MaxRink Awaiting requested review from MaxRink

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@killianmuldoon @k8s-ci-robot @MrDXY @chrischdi